This repository has been archived by the owner on Mar 25, 2018. It is now read-only.
Remove style guide (moved to nodejs/node) #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
The linked PR (nodejs/node#11321) has now landed in node, so unless anyone has any objections we should get this landed. |
Also fixup links.
|
Now depends on nodejs/node#11460 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@sam-github could you land? |
sam-github
pushed a commit
that referenced
this pull request
Feb 22, 2017
Also fixup links. PR-URL: #123 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
@sam-github no, I'm not a member of the docs team. I would like to be though, not sure what the application process is. |
|
@gibfahn I’ve added you to the team… I personally got added by just requesting it via the github interface, so I think it should be okay? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Move the STYLE_GUIDE.md from here to
nodejs/node(see linked PR: nodejs/node#11321):Following discussion in nodejs/node#11286 (comment), I think it makes more sense to have the style guide in the core repo.
I'm happy to discuss, but we should keep discussion in one PR, so if you have any comments could you make them in nodejs/node#11321 so we can have the discussion in one place?
Also fixes the links in
GETTING-STARTED.mdand.editorconfig