labels: fix for files in internal subdirectories (#147)

nodejs · Jun 23, 2017 · 24a7945 · 24a7945
1 parent dd08aaf
commit 24a7945
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/node-labels.js b/lib/node-labels.js
@@ -89,7 +89,7 @@ const subSystemLabelsMap = new Map([
   // All other lib/ files map directly
   [/^lib\/_(\w+)_\w+\.js?$/, '$1'], // e.g. _(stream)_wrap
   [/^lib(\/internal)?\/(\w+)\.js?$/, '$2'], // other .js files
-  [/^lib\/internal\/(\w+)$/, '$1'] // internal subfolders
+  [/^lib\/internal\/(\w+)(?:\/|$)/, '$1'] // internal subfolders
 ])
 
 const jsSubsystemList = [

diff --git a/test/unit/node-js-subsystem-labels.test.js b/test/unit/node-js-subsystem-labels.test.js
@@ -161,3 +161,14 @@ tap.test('label: "doc,module" when doc/api/modules.md was changed', (t) => {
 
   t.end()
 })
+
+tap.test('label: appropriate labels for files in internal subdirectories', (t) => {
+  const labels = nodeLabels.resolveLabels([
+    'lib/internal/cluster/master.js',
+    'lib/internal/process/next_tick.js'
+  ], false)
+
+  t.same(labels, ['cluster', 'process'])
+
+  t.end()
+})