Skip to content

Commit

Permalink
chore: update github v12 > v13 due to vulnerability in https-proxy-agent
Browse files Browse the repository at this point in the history
Since this is a major update of *the* most important dependency in this
project, namely the one we use to communicate to github with, it
deserves its own bump commit, making it easier to revert in case any
surprises are found.

Ideally we would jump to the latest and greatest version of this
dependency, which has even been renamed to `@octokit/rest`, but doing
so sadly breakes a lot of tests ATM. Will have to look into that later.

Refs https://www.npmjs.com/advisories/1184
  • Loading branch information
phillipj committed Mar 22, 2020
1 parent 3b21a21 commit c829ad5
Show file tree
Hide file tree
Showing 2 changed files with 50 additions and 50 deletions.
98 changes: 49 additions & 49 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"debug": "^2.2.0",
"dotenv": "^2.0.0",
"express": "^4.13.4",
"github": "^12.1.0",
"github": "^13.1.1",
"glob": "^7.0.3",
"lru-cache": "^4.0.1",
"request": "^2.88.0"
Expand Down

0 comments on commit c829ad5

Please sign in to comment.