-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node core auto labeling improvements #31
Labels
Comments
This was referenced Apr 20, 2016
We may want to blacklist |
I've been considering adding a |
@Fishrock123 @jasnell fixed it in #32 by ignoring |
Closing this for now as the originally mentioned labels has been fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Low hanging fruits
doc/
for docbenchmark/
for benchmarkdeps/$name
-> $name (libuv, v8, etc)configure
,*Makefile
,node.gyp
,common.gypi
->build
(a lot of stuff in tools/ lives here too but not necessarily low hanging fruit)To avoid duplicate work on these, please leave a comment if you'd like to give some of these a shot.
Challenges
Regarding the
c++
label for any PR that has file changes insrc/
:How to work on this
Its current labels brain is located in lib/node-labels.js#resolveLabels(). It's even covered by tests test/node-labels.test.js.
Refs nodejs/node#6247
The text was updated successfully, but these errors were encountered: