Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2016-04-26, Version 6.0.0 (Current) Release #6383

Closed
wants to merge 1 commit into from
Closed

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Apr 26, 2016

@nodejs/ctc @nodejs/collaborators ... Please take a good look at the notable changes. There are some updates that need to be made and likely stuff that I missed. I will be cutting the v6 release tomorrow morning.

The following significant (semver-major) changes have been made since the
previous Node v5.0.0 release.

  • Buffer
    • New Buffer constructors have been added
      #4682
    • Previously deprecated Buffer APIs are removed
      #5048,
      #4594
    • Improved error handling #4514
  • Cluster
    • Worker emitted as first argument in 'message' event
      #5361.
  • Crypto
    • Improved error handling #3100,
      #5611
    • Simplified Certificate class bindings
      #5382
    • Improved control over FIPS mode
      #5181
    • pbkdf2 digest overloading is deprecated
      #4047
  • Dependencies
    • Reintroduce shared c-ares build support
      #5775.
    • V8 updated to 5.0.71.31 #6111.
  • DNS
    • Add resolvePtr API to query plain DNS PTR records
      #4921.
  • Domains
    • Clear stack when no error handler
      #4659.
  • File System
    • The fs.realpath() and fs.realpathSync() methods have been updated
      to use a more efficient libuv implementation. This change includes the
      removal of the cache argument and the method can throw new errors
      #3594
    • FS apis can now accept and return paths as Buffers
      #5616.
    • Error handling and type checking improvements
      #5616,
      #5590,
      #4518,
      #3917.
    • fs.read's string interface is deprecated
      #4525
  • HTTP
    • 'clientError' can now be used to return custom errors from an
      HTTP server #4557.
  • Modules
    • Current directory is now prioritized for local lookups
      #5689
    • Symbolic links are preserved when requiring modules
      #5950
  • Net
    • DNS hints no longer implicitly set
      #6021.
    • Improved error handling and type checking
      #5981,
      #5733,
      #2904
  • Path
    • Improved type checking #5348.
  • Process
    • Introduce process warnings API
      #4782.
    • Throw exception when non-function passed to nextTick
      #3860.
  • Readline
    • Emit key info unconditionally
      #6024
  • REPL
    • Assignment to _ will emit a warning.
      #5535
  • Timers
    • Fail early when callback is not a function
      #4362
  • TLS
    • Rename 'clientError' to 'tlsClientError'
      #4557
    • SHA1 used for sessionIdContext
      #3866
  • TTY
    • Previously deprecated setRawMode wrapper is removed
      #2528.
  • Util
    • Changes to Error object formatting
      #4582.
  • Windows
    • Windows XP and Vista are no longer supported
      #5167,
      #5167.

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Apr 26, 2016
@evanlucas
Copy link
Contributor

Also, #3743 just landed

@mscdex
Copy link
Contributor

mscdex commented Apr 26, 2016

minor nit:

The fs.realpath() and fs.realpathSync() methods have been updated to use a more efficient libuv implementation

makes it sound like it was using libuv before, but less efficiently. How about:

The fs.realpath() and fs.realpathSync() methods have been updated to use a more efficient, libuv-based implementation

?

@jasnell jasnell added this to the 6.0.0 milestone Apr 26, 2016
@Fishrock123 Fishrock123 removed the c++ Issues and PRs that require attention from people who are familiar with C++. label Apr 26, 2016
@vsemozhetbyt
Copy link
Contributor

#6352 just landed.

@zheung
Copy link

zheung commented Apr 26, 2016

the greatest news in this morning!

@mscdex mscdex added the meta Issues and PRs related to the general management of the project. label Apr 26, 2016
* Windows
* Windows XP and Vista are no longer supported
[#5167](https://github.com/nodejs/node/pull/5167),
[#5167](https://github.com/nodejs/node/pull/5167).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this was pointed out before in the RCs, but this link is duplicated

@jasnell jasnell mentioned this pull request Apr 26, 2016
@egoroof

This comment was marked as abuse.

@MylesBorins
Copy link
Contributor

@egoroof nvm draws directly from our release json... it will be ready as soon as we publish it.

I have been chatting with @ljharb about how to offer better support for rc's in nvm

here is a workaround

@ljharb
Copy link
Member

ljharb commented Apr 26, 2016

Re the workaround, please note https://twitter.com/ljharb/status/724815514338512897

@micnic
Copy link
Contributor

micnic commented Apr 26, 2016

Windows XP and Vista are no longer supported #5167, #5167.

#5167 is mentioned twice

@Fishrock123
Copy link
Contributor

Still not comfortable with the Stable -> Current rename without prior public messaging.

@jasnell
Copy link
Member Author

jasnell commented Apr 26, 2016

@ljharb ... regarding nvm... it's being proposed in this release to change from using the label stable to using the label current for the Stable branches. Would that throw off nvm at all?

@jasnell
Copy link
Member Author

jasnell commented Apr 26, 2016

Rebased and updated. Will Rebase and update again shortly.

@Fishrock123
Copy link
Contributor

Looks like the foundation is already doing messaging in favor of this: nodejs/nodejs.org#672 (comment)

Rest in peace, Stable. Long live Current.

@ljharb
Copy link
Member

ljharb commented Apr 26, 2016

@jasnell no, "stable" is a synonym for "node", and i won't be adding "current" - "node" is what people should be using for "latest". "stable" is a pre-semver concept anyways, as version numbers don't convey stability in semver, so I'm glad it's being removed.

"stable" will remain for awhile as a legacy default alias, just like "unstable" does (pointing to 0.11).

@jasnell
Copy link
Member Author

jasnell commented Apr 26, 2016

Ok, calling time on things getting into v6 now. I've got a few more cleanups to do, then will start the smoke testing and build process. Thanks all!

@ChALkeR
Copy link
Member

ChALkeR commented Apr 26, 2016

@jasnell, any chance to get #6402 in?

@jasnell
Copy link
Member Author

jasnell commented Apr 26, 2016

Initial CI run : https://ci.nodejs.org/job/node-test-pull-request/2402/ (does not include #6402)

@MylesBorins
Copy link
Contributor

MylesBorins commented Apr 26, 2016

Initial citgm run: https://ci.nodejs.org/view/Node.js-citgm/job/thealphanerd-smoker/216/

edit: it is worth mentioning that we should expect failures in both body-parser and node-glob

The body-parser failures are test only, and there is a fix being landed in the project
node-glob uncovered an edge case in the new realpath implementation. A fix has been proposed but is still being evaluated. The fix needs to be implemented in glob though, not node

@jasnell
Copy link
Member Author

jasnell commented Apr 26, 2016

New run to hopefully get a good centos build: https://ci-release.nodejs.org/job/iojs+release/555/
/cc @nodejs/build -- looks like the centos system went offline during the build. Hoping it's back up but can you please keep an eye on it

@MylesBorins
Copy link
Contributor

OSX is done.

There is some unexpected stuff going on in request that I am digging into... it looks like it might be related to some changes affecting fsevents. I'll update this comment with the investigation.

The following significant (semver-major) changes have been made since the
previous Node v5.0.0 release.

* Buffer
  * New Buffer constructors have been added
    [#4682](#4682)
  * Previously deprecated Buffer APIs are removed
    [#5048](#5048),
    [#4594](#4594)
  * Improved error handling [#4514](#4514)
* Cluster
  * Worker emitted as first argument in 'message' event
    [#5361](#5361).
* Crypto
  * Improved error handling [#3100](#3100),
    [#5611](#5611)
  * Simplified Certificate class bindings
    [#5382](#5382)
  * Improved control over FIPS mode
    [#5181](#5181)
  * pbkdf2 digest overloading is deprecated
    [#4047](#4047)
* Dependencies
  * Reintroduce shared c-ares build support
    [#5775](#5775).
  * V8 updated to 5.0.71.31 [#6111](#6111).
* DNS
  * Add resolvePtr API to query plain DNS PTR records
    [#4921](#4921).
* Domains
  * Clear stack when no error handler
  [#4659](#4659).
* File System
  * The `fs.realpath()` and `fs.realpathSync()` methods have been updated
    to use a more efficient libuv implementation. This change includes the
    removal of the `cache` argument and the method can throw new errors
    [#3594](#3594)
  * FS apis can now accept and return paths as Buffers
    [#5616](#5616).
  * Error handling and type checking improvements
    [#5616](#5616),
    [#5590](#5590),
    [#4518](#4518),
    [#3917](#3917).
  * fs.read's string interface is deprecated
    [#4525](#4525)
* HTTP
  * 'clientError' can now be used to return custom errors from an
    HTTP server [#4557](#4557).
* Modules
  * Current directory is now prioritized for local lookups
    [#5689](#5689)
  * Symbolic links are preserved when requiring modules
    [#5950](#5950)
* Net
  * DNS hints no longer implicitly set
    [#6021](#6021).
  * Improved error handling and type checking
    [#5981](#5981),
    [#5733](#5733),
    [#2904](#2904)
* OS X
  * MACOSX_DEPLOYMENT_TARGET has been bumped up to 10.7
    [#6402](#6402).
* Path
  * Improved type checking [#5348](#5348).
* Process
  * Introduce process warnings API
    [#4782](#4782).
  * Throw exception when non-function passed to nextTick
    [#3860](#3860).
* Readline
  * Emit key info unconditionally
    [#6024](#6024)
* REPL
  * Assignment to `_` will emit a warning.
    [#5535](#5535)
* Timers
  * Fail early when callback is not a function
    [#4362](#4362)
* TLS
  * Rename 'clientError' to 'tlsClientError'
    [#4557](#4557)
  * SHA1 used for sessionIdContext
    [#3866](#3866)
* TTY
  * Previously deprecated setRawMode wrapper is removed
    [#2528](#2528).
* Util
  * Changes to Error object formatting
    [#4582](#4582).
* Windows
  * Windows XP and Vista are no longer supported
    [#5167](#5167),
    [#5167](#5167).
@jasnell
Copy link
Member Author

jasnell commented Apr 26, 2016

New Release Build Run: https://ci-release.nodejs.org/job/iojs+release/557/

@jasnell
Copy link
Member Author

jasnell commented Apr 26, 2016

(fingers crossed Jenkins behaves)

@jamen
Copy link
Contributor

jamen commented Apr 26, 2016

GitHub needs fingers crossed reaction? Lol.

@jasnell
Copy link
Member Author

jasnell commented Apr 26, 2016

It definitely needs "Hold your Breath" and "Rage Quit" reactions for sure

@jasnell
Copy link
Member Author

jasnell commented Apr 26, 2016

Can I ask anyone who is waiting for this build to complete to do some extra testing of request on OSX?

@jasnell
Copy link
Member Author

jasnell commented Apr 26, 2016

image

jasnell added a commit that referenced this pull request Apr 26, 2016
@dnalborczyk
Copy link
Contributor

dnalborczyk commented Apr 26, 2016

@jasnell are you building of "v6.0.0-proposal"? The test case for tick processor is failing again on OSX El Capitan 10.11.5 - and so is "master".

@jasnell
Copy link
Member Author

jasnell commented Apr 26, 2016

@dnalborczyk, no, building off v6.x

@jasnell
Copy link
Member Author

jasnell commented Apr 26, 2016

Done! Released!

@jasnell jasnell closed this Apr 26, 2016
@jamen
Copy link
Contributor

jamen commented Apr 26, 2016

That face when the changelog file too big for GitHub to display now.

ThomasLomas added a commit to ThomasLomas/docker-node that referenced this pull request Apr 26, 2016
@silverwind
Copy link
Contributor

@jamen that just got fixed!

@jamen
Copy link
Contributor

jamen commented Apr 26, 2016

You sure about that? Link from the website actually still displays as too big for me. Though the one in the repo seems to work. Linking to different branch?

@jasnell
Copy link
Member Author

jasnell commented Apr 26, 2016

@jamen: yeah, it was fixed in master, need to backport that change into v6 now tho ;-) It might be the first backport into v6

@temaivanoff
Copy link

temaivanoff commented Apr 27, 2016

@jasnell @Fishrock123 Hi, Debian and Ubuntu based Linux distributions package-manager not found setup_6.x =)

@thefourtheye
Copy link
Contributor

@jasnell Can this branch be deleted now?

@targos
Copy link
Member

targos commented Apr 27, 2016

more general question: can we delete all the vx.y.z-proposal branches ?

@jasnell
Copy link
Member Author

jasnell commented Apr 27, 2016

Yep! I was planning to do some housekeeping today and clean those up, but
you're more than welcome to do so also!
On Apr 27, 2016 4:05 AM, "Michaël Zasso" notifications@github.com wrote:

more general question: can we delete all the vx.y.z-proposal branches ?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#6383 (comment)

@targos targos deleted the v6.0.0-proposal branch April 27, 2016 13:01
@kzc
Copy link

kzc commented Apr 27, 2016

Noticed that the 6.0.0 change log was missing an entry for this fix:

#4222 Node ignoring redirections when redirected to a tty

It was part of the libuv 1.9.0 merge.

@jasnell
Copy link
Member Author

jasnell commented Apr 27, 2016

Yeah it seems the change log is missing quite a few commits, just not quite
sure how they were missed. I'll be fixing that later on today.
On Apr 27, 2016 11:49 AM, "kzc" notifications@github.com wrote:

Noticed that the 6.0.0 change log was missing an entry for this fix:

#4222 #4222 Node ignoring
redirections when redirected to a tty

It was part of the libuv 1.9.0 merge.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#6383 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.