Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bad tagging for test #33

Closed
mscdex opened this issue Apr 28, 2016 · 1 comment · Fixed by #34
Closed

bad tagging for test #33

mscdex opened this issue Apr 28, 2016 · 1 comment · Fixed by #34

Comments

@mscdex
Copy link
Contributor

mscdex commented Apr 28, 2016 •
edited
Loading

In this PR, the bot tagged the PR with test but the PR did not strictly contain test(s), it had changes in lib/ too.
@phillipj
Copy link
Member

Bad bot! 🐩 Thanks for reporting

phillipj added a commit that referenced this issue Apr 28, 2016
@phillipj
Fix for bad node core PR exclusive labels.
95ec68a 
This fixes some bad labelling by ensuring that *every* file affected in
the PR actually matches an exclusive label when we're checking for exclusive labels.

Refs nodejs/node#6448 nodejs/node#6432
Closes #33
@phillipj phillipj mentioned this issue Apr 28, 2016
Merged
phillipj added a commit that referenced this issue Apr 28, 2016
@phillipj
Fix for bad node core PR exclusive labels. (#34)
a2c330d 
This fixes some bad labelling by ensuring that *every* file affected in
the PR actually matches an exclusive label when we're checking for exclusive labels.

Refs nodejs/node#6448 nodejs/node#6432
Closes #33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for bad node core PR exclusive labels. nodejs/github-bot
2 participants
@mscdex @phillipj