Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

label: mark all quic change as dont-land-v14.x #267

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

MylesBorins
Copy link
Contributor

As per discussion on GitHub it does not appear that QUIC is intended
to be backported to v14.x, add appropriate label.

/cc @jasnell to confirm

@richardlau
Copy link
Member

@MylesBorins That also implies we should add the other dont-land-* labels (e.g. dont-land-v12.x)?

@MylesBorins
Copy link
Contributor Author

I've added the dont-land-v12.x label as well. Did not include 10.x as it is in maintenance

Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The labels are dont-land-on-vnn.x

As per discussion on GitHub it does not appear that QUIC is intended
to be backported to v14.x, add appropriate label.
@MylesBorins
Copy link
Contributor Author

@targos PTAL

@MylesBorins MylesBorins merged commit 14e96ca into nodejs:master Jul 29, 2020
@MylesBorins
Copy link
Contributor Author

is there anything else we need to do to deploy this? Do we have CD in place?

@phillipj
Copy link
Member

CD is setup, yes. The bot automatically gets deployed when changes lands in master 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants