Add JS (lib/) subsystem labels #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [/^lib(\/\w+)?\/(_)?link(ed)?list/, 'timers'], | ||
| [/^lib\/\w+\/bootstrap_node/, 'lib / src'], | ||
| [/^lib\/\w+\/v8_prof_/, 'tools'], | ||
| [/^lib\/\w+\/socket_list/, 'net'], |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Fishrock123
force-pushed
the
labels/lib-subsystem
branch
from
9849685 to
82a93fa
Compare
|
Rebased on |
| [/^deps\/([^/]+)/, '$1'], | ||
|
|
||
| /* JS subsystems */ | ||
| // Oddities first |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
LGTM 👍 |
Fishrock123
force-pushed
the
labels/lib-subsystem
branch
from
82a93fa to
35657c0
Compare
|
Updated a bit, condensed some of the oddities a bit. |
|
@Fishrock123 deployed We're now running v6 in production 👯 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #41
Does some.. fancy.. mapping for some of the outliers.
Also limits the labels to 4, and just uses
lib / srcat 5.cc @phillipj