Skip to content

Commit

Permalink
fix: support empty dictionary keys in input (#245)
Browse files Browse the repository at this point in the history
* fix: support empty dictionary keys in input

Certain old keys in `msvs_settings` (like "LinkIncremental") are moved
to the top level when translated to `msbuild_settings`.
This change allows to set them when `msbuild_settings` are
authored directly.

* Update pylib/gyp/input.py

Co-authored-by: Christian Clauss <cclauss@me.com>

---------

Co-authored-by: Christian Clauss <cclauss@me.com>
  • Loading branch information
targos and cclauss authored Apr 29, 2024
1 parent e3f0cb9 commit 178459f
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pylib/gyp/input.py
Original file line number Diff line number Diff line change
Expand Up @@ -2536,6 +2536,8 @@ def ProcessListFiltersInDict(name, the_dict):
lists = []
del_lists = []
for key, value in the_dict.items():
if not key:
continue
operation = key[-1]
if operation not in {"!", "/"}:
continue
Expand Down

0 comments on commit 178459f

Please sign in to comment.