Skip to content

Commit

Permalink
pyupgrade --py36-plus **/*.py (#112)
Browse files Browse the repository at this point in the history
  • Loading branch information
cclauss committed Jun 22, 2021
1 parent d47ed53 commit 45475a7
Show file tree
Hide file tree
Showing 9 changed files with 22 additions and 29 deletions.
2 changes: 1 addition & 1 deletion pylib/gyp/MSVSUtil.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def _SuffixName(name, suffix):
Target name with suffix added (foo_suffix#target)
"""
parts = name.rsplit("#", 1)
parts[0] = "{}_{}".format(parts[0], suffix)
parts[0] = f"{parts[0]}_{suffix}"
return "#".join(parts)


Expand Down
2 changes: 1 addition & 1 deletion pylib/gyp/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,7 @@ def pop(self, last=True): # pylint: disable=W0221
def __repr__(self):
if not self:
return f"{self.__class__.__name__}()"
return "{}({!r})".format(self.__class__.__name__, list(self))
return f"{self.__class__.__name__}({list(self)!r})"

def __eq__(self, other):
if isinstance(other, OrderedSet):
Expand Down
2 changes: 1 addition & 1 deletion pylib/gyp/easy_xml.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def _ConstructContentList(xml_parts, specification, pretty, level=0):
rest = specification[1:]
if rest and isinstance(rest[0], dict):
for at, val in sorted(rest[0].items()):
xml_parts.append(' {}="{}"'.format(at, _XmlEscape(val, attr=True)))
xml_parts.append(f' {at}="{_XmlEscape(val, attr=True)}"')
rest = rest[1:]
if rest:
xml_parts.append(">")
Expand Down
6 changes: 3 additions & 3 deletions pylib/gyp/generator/android.py
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ def WriteActions(self, actions, extra_sources, extra_outputs):
for output in outputs[1:]:
# Make each output depend on the main output, with an empty command
# to force make to notice that the mtime has changed.
self.WriteLn("{}: {} ;".format(self.LocalPathify(output), main_output))
self.WriteLn(f"{self.LocalPathify(output)}: {main_output} ;")

extra_outputs += outputs
self.WriteLn()
Expand Down Expand Up @@ -616,7 +616,7 @@ def WriteSources(self, spec, configs, extra_sources):
if IsCPPExtension(ext) and ext != local_cpp_extension:
local_file = root + local_cpp_extension
if local_file != source:
self.WriteLn("{}: {}".format(local_file, self.LocalPathify(source)))
self.WriteLn(f"{local_file}: {self.LocalPathify(source)}")
self.WriteLn("\tmkdir -p $(@D); cp $< $@")
origin_src_dirs.append(os.path.dirname(source))
final_generated_sources.append(local_file)
Expand Down Expand Up @@ -908,7 +908,7 @@ def WriteTarget(
if isinstance(v, list):
self.WriteList(v, k)
else:
self.WriteLn("{} := {}".format(k, make.QuoteIfNecessary(v)))
self.WriteLn(f"{k} := {make.QuoteIfNecessary(v)}")
self.WriteLn("")

# Add to the set of targets which represent the gyp 'all' target. We use the
Expand Down
2 changes: 1 addition & 1 deletion pylib/gyp/generator/make.py
Original file line number Diff line number Diff line change
Expand Up @@ -2133,7 +2133,7 @@ def WriteSortedXcodeEnv(self, target, env):
# export foo := a\ b
# it does not -- the backslash is written to the env as literal character.
# So don't escape spaces in |env[k]|.
self.WriteLn("{}: export {} := {}".format(QuoteSpaces(target), k, v))
self.WriteLn(f"{QuoteSpaces(target)}: export {k} := {v}")

def Objectify(self, path):
"""Convert a path to its output directory form."""
Expand Down
6 changes: 3 additions & 3 deletions pylib/gyp/generator/msvs.py
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ def _ConfigBaseName(config_name, platform_name):

def _ConfigFullName(config_name, config_data):
platform_name = _ConfigPlatform(config_data)
return "{}|{}".format(_ConfigBaseName(config_name, platform_name), platform_name)
return f"{_ConfigBaseName(config_name, platform_name)}|{platform_name}"


def _ConfigWindowsTargetPlatformVersion(config_data, version):
Expand All @@ -335,15 +335,15 @@ def _ConfigWindowsTargetPlatformVersion(config_data, version):
# Find a matching entry in sdk_dir\include.
expected_sdk_dir = r"%s\include" % sdk_dir
names = sorted(
[
(
x
for x in (
os.listdir(expected_sdk_dir)
if os.path.isdir(expected_sdk_dir)
else []
)
if x.startswith(version)
],
),
reverse=True,
)
if names:
Expand Down
2 changes: 1 addition & 1 deletion pylib/gyp/generator/ninja.py
Original file line number Diff line number Diff line change
Expand Up @@ -638,7 +638,7 @@ def GenerateDescription(self, verb, message, fallback):
if self.toolset != "target":
verb += "(%s)" % self.toolset
if message:
return "{} {}".format(verb, self.ExpandSpecial(message))
return f"{verb} {self.ExpandSpecial(message)}"
else:
return f"{verb} {self.name}: {fallback}"

Expand Down
8 changes: 4 additions & 4 deletions pylib/gyp/xcodeproj_file.py
Original file line number Diff line number Diff line change
Expand Up @@ -299,8 +299,8 @@ def __repr__(self):
try:
name = self.Name()
except NotImplementedError:
return "<{} at 0x{:x}>".format(self.__class__.__name__, id(self))
return "<{} {!r} at 0x{:x}>".format(self.__class__.__name__, name, id(self))
return f"<{self.__class__.__name__} at 0x{id(self):x}>"
return f"<{self.__class__.__name__} {name!r} at 0x{id(self):x}>"

def Copy(self):
"""Make a copy of this object.
Expand Down Expand Up @@ -2251,7 +2251,7 @@ class PBXContainerItemProxy(XCObject):
def __repr__(self):
props = self._properties
name = "{}.gyp:{}".format(props["containerPortal"].Name(), props["remoteInfo"])
return "<{} {!r} at 0x{:x}>".format(self.__class__.__name__, name, id(self))
return f"<{self.__class__.__name__} {name!r} at 0x{id(self):x}>"

def Name(self):
# Admittedly not the best name, but it's what Xcode uses.
Expand Down Expand Up @@ -2288,7 +2288,7 @@ class PBXTargetDependency(XCObject):

def __repr__(self):
name = self._properties.get("name") or self._properties["target"].Name()
return "<{} {!r} at 0x{:x}>".format(self.__class__.__name__, name, id(self))
return f"<{self.__class__.__name__} {name!r} at 0x{id(self):x}>"

def Name(self):
# Admittedly not the best name, but it's what Xcode uses.
Expand Down
21 changes: 7 additions & 14 deletions test_gyp.py
Original file line number Diff line number Diff line change
Expand Up @@ -140,10 +140,7 @@ def main(argv=None):
if not args.quiet:
runner.print_results()

if runner.failures:
return 1
else:
return 0
return 1 if runner.failures else 0


def print_configuration_info():
Expand All @@ -152,8 +149,8 @@ def print_configuration_info():
sys.path.append(os.path.abspath("test/lib"))
import TestMac

print(" Mac {} {}".format(platform.mac_ver()[0], platform.mac_ver()[2]))
print(" Xcode %s" % TestMac.Xcode.Version())
print(f" Mac {platform.mac_ver()[0]} {platform.mac_ver()[2]}")
print(f" Xcode {TestMac.Xcode.Version()}")
elif sys.platform == "win32":
sys.path.append(os.path.abspath("pylib"))
import gyp.MSVSVersion
Expand All @@ -162,8 +159,8 @@ def print_configuration_info():
print(" MSVS %s" % gyp.MSVSVersion.SelectVisualStudioVersion().Description())
elif sys.platform in ("linux", "linux2"):
print(" Linux %s" % " ".join(platform.linux_distribution()))
print(" Python %s" % platform.python_version())
print(" PYTHONPATH=%s" % os.environ["PYTHONPATH"])
print(f" Python {platform.python_version()}")
print(f" PYTHONPATH={os.environ['PYTHONPATH']}")
print()


Expand Down Expand Up @@ -222,13 +219,9 @@ def run_test(self, test, fmt, i):
res_msg = f" {res} {took:.3f}s"
self.print_(res_msg)

if (
stdout
and not stdout.endswith("PASSED\n")
and not (stdout.endswith("NO RESULT\n"))
):
if stdout and not stdout.endswith(("PASSED\n", "NO RESULT\n")):
print()
print("\n".join(" %s" % line for line in stdout.splitlines()))
print("\n".join(f" {line}" for line in stdout.splitlines()))
elif not self.isatty:
print()

Expand Down

0 comments on commit 45475a7

Please sign in to comment.