fix: compile_commands.json generation (#22)

Add default fallback output directory.
nodejs · Apr 3, 2020 · afa06c4 · afa06c4
1 parent 540a8a1
commit afa06c4
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pylib/gyp/generator/compile_commands_json.py b/pylib/gyp/generator/compile_commands_json.py
@@ -42,7 +42,7 @@ def CalculateVariables(default_variables, params):
 
 
 def AddCommandsForTarget(cwd, target, params, per_config_commands):
-    output_dir = params["generator_flags"]["output_dir"]
+    output_dir = params["generator_flags"].get("output_dir", "out")
     for configuration_name, configuration in target["configurations"].items():
         builddir_name = os.path.join(output_dir, configuration_name)
 
@@ -110,7 +110,7 @@ def GenerateOutput(target_list, target_dicts, data, params):
         cwd = os.path.dirname(build_file)
         AddCommandsForTarget(cwd, target, params, per_config_commands)
 
-    output_dir = params["generator_flags"]["output_dir"]
+    output_dir = params["generator_flags"].get("output_dir", "out")
     for configuration_name, commands in per_config_commands.items():
         filename = os.path.join(output_dir, configuration_name, "compile_commands.json")
         gyp.common.EnsureDirExists(filename)