Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use 3.11 for integration tests #199

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

rzhao271
Copy link
Contributor

@rzhao271 rzhao271 commented Jun 22, 2023

This PR changes the CI to use Python 3.11 instead of 3.10, and attempts to fix a small deprecation warning.

It also adds a new lint ignore rule for ruff because CI gave the following errors:

Run ruff --format=github .
Error: pylib/gyp/generator/ninja.py:2095:24: RUF012 Mutable class attributes should be annotated with `typing.ClassVar`
Error: pylib/gyp/xcode_emulation.py:153:23: RUF012 Mutable class attributes should be annotated with `typing.ClassVar`
Error: pylib/gyp/xcode_emulation.py:154:28: RUF012 Mutable class attributes should be annotated with `typing.ClassVar`
Error: pylib/gyp/xcode_emulation.py:155:23: RUF012 Mutable class attributes should be annotated with `typing.ClassVar`
Error: pylib/gyp/xcode_emulation.py:159:20: RUF012 Mutable class attributes should be annotated with `typing.ClassVar`
Error: pylib/gyp/xcode_emulation.py:163:30: RUF012 Mutable class attributes should be annotated with `typing.ClassVar`
Error: pylib/gyp/xcodeproj_file.py:268:15: RUF012 Mutable class attributes should be annotated with `typing.ClassVar`
Error: pylib/gyp/xcodeproj_file.py:272:26: RUF012 Mutable class attributes should be annotated with `typing.ClassVar`
Error: pylib/gyp/xcodeproj_file.py:285:36: RUF012 Mutable class attributes should be annotated with `typing.ClassVar`
Error: pylib/gyp/xcodeproj_file.py:1685:16: RUF012 Mutable class attributes should be annotated with `typing.ClassVar`
Error: pylib/gyp/xcodeproj_file.py:2071:36: RUF012 Mutable class attributes should be annotated with `typing.ClassVar`
Error: pylib/gyp/xcodeproj_file.py:2080:37: RUF012 Mutable class attributes should be annotated with `typing.ClassVar`
Error: pylib/gyp/xcodeproj_file.py:2460:26: RUF012 Mutable class attributes should be annotated with `typing.ClassVar`
Error: Process completed with exit code 1.

@cclauss
Copy link
Contributor

cclauss commented Jun 22, 2023

@dhruvmanila Can you please propose solutions to ruff rule RUF012 in a separate pull request when you get a chance?

@cclauss cclauss merged commit 1e574ee into nodejs:main Jul 17, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants