chore: pyproject.toml: dependencies = ["packaging>=24.0"] #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendecas
reviewed
May 6, 2024
| @@ -12,8 +12,7 @@ description = "A fork of the GYP build system for use in the Node.js projects" | |||
| readme = "README.md" | |||
| license = { file="LICENSE" } | |||
| requires-python = ">=3.8" | |||
| # The Python module "packaging" is vendored in the "pylib/packaging" directory to support Python >= 3.12. | |||
| # dependencies = ["packaging>=23.1"] # Uncomment this line if the vendored version is removed. | |||
There was a problem hiding this comment.
Should we remove the vendored packaging source code as well?
There was a problem hiding this comment.
My preference would be to do this in two steps even if there is a bit of duplication.
legendecas
approved these changes
May 6, 2024
|
I think it would be still necessary to have the vendored packaging source to be used in the nodejs core repo with python 3.12 support. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #249
ModuleNotFoundError: No module named 'packaging'on Py3.12 #249