Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): add Python 3.13 pre-release to test matrix #257

Merged

Conversation

DeeDeeG
Copy link
Contributor

@DeeDeeG DeeDeeG commented May 11, 2024

Add Python 3.13 to the CI test matrix for gyp-next repo.

Python 3.13 is in beta now, and will be stable soonish (October 2024).

This PR relates to #219. There was some enthusiasm there in a comment: #219 (comment) so I figured I'd open a PR for this real quick.

(Commentary: For what it's worth, gyp-next tests have been passing with Python 3.13 on my personal fork for some time now, even when Python 3.13 was still in alpha. But now it's in beta, so this should be a reasonable time to start testing against it in the official repo?)

This version of Python is in beta now, and will be stable soonish.
.github/workflows/node-gyp.yml Outdated Show resolved Hide resolved
.github/workflows/node-gyp.yml Outdated Show resolved Hide resolved
.github/workflows/python_tests.yml Outdated Show resolved Hide resolved
.github/workflows/python_tests.yml Outdated Show resolved Hide resolved
@cclauss cclauss self-assigned this May 12, 2024
@cclauss cclauss added the python Pull requests that update Python code label May 12, 2024
macos-latest runners now resolve to macos-14.

(To be precise: the transition is still rolling out across some repos,
according to the announcement post, but workflows that have already
migrated won't switch back. The relevant workflows at this repo have
already migrated, so the explicit macos-14 jobs are now redundant
to the implicit macOS 14 (macos-latest) jobs, and can be removed
from the text matrix now.)

Making this change per review feedback on the PR.

Co-authored-by: Christian Clauss <cclauss@me.com>
@DeeDeeG
Copy link
Contributor Author

DeeDeeG commented May 12, 2024

Note: I suppose the PR title could be edited to a semantic release commit message, like chore(ci): add Python 3.13 to test matrix, but the chore prefix is excluded from release-please changelogs by default anyhow, so it wouldn't make a ton of difference.

If maintainers here want to change the PR title I'd be fine with that. Leaving it to maintainers to decide.

@cclauss cclauss changed the title GitHub Actions add Python 3.13 to test matrix fix(ci): add Python 3.13 pre-release to test matrix May 12, 2024
@cclauss cclauss merged commit 8597203 into nodejs:main May 12, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants