Skip to content
This repository has been archived by the owner on Nov 6, 2022. It is now read-only.

incorrect handling of upgrade header for messages with non-empty body (e.g. POST) #234

Closed
KjellSchubert opened this issue Apr 20, 2015 · 0 comments
Closed

incorrect handling of upgrade header for messages with non-empty body (e.g. POST) #234

KjellSchubert opened this issue Apr 20, 2015 · 0 comments

Comments

@KjellSchubert
Copy link
Contributor

This is one of the bugfixes in the Proxygen fork of http_parser: http_parser handling of the Upgrade header isn't really correct. If it sees an Upgrade header it immediately gives an onMessageComplete callback, sets the parser state to a new message and returns. For messages with an entity body, the upgrade wouldn't take effect until after the body was sent.
KjellSchubert added a commit to KjellSchubert/http-parser that referenced this issue Apr 20, 2015
@KjellSchubert
Closes nodejs#234: No immediate onMessageComplete cb for upgrade w/bo…
a74eb90 
…dy (D1364677 + D1380182 orig author afrind@fb.com)
KjellSchubert added a commit to KjellSchubert/http-parser that referenced this issue Apr 22, 2015
@KjellSchubert
Squashed commit of the following:
50019e6 
commit 0446aba
Author: Kjell Schubert <kschubert@fb.com>
Date:   Wed Apr 22 09:45:13 2015 -0700

    restore line-trailing whitespace to minimize diff

commit 7b48104
Author: Kjell Schubert <kjell.schubert@gmail.com>
Date:   Mon Apr 20 15:52:13 2015 -0700

    these are changes needed on top of the original proxygen changesets

commit a74eb90
Author: Kjell Schubert <kjell.schubert@gmail.com>
Date:   Fri Apr 17 16:25:11 2015 -0700

    Closes nodejs#234: No immediate onMessageComplete cb for upgrade w/body (D1364677 + D1380182 orig author afrind@fb.com)
indutny pushed a commit that referenced this issue Apr 23, 2015
@KjellSchubert @indutny
src: support body in Upgrade requests
dff604d 
Invoke message_complete cb for upgrade with body.

(D1364677 + D1380182 orig author afrind@fb.com)

Fix: #234
PR-URL: #235
Reviewed-By: Fedor Indutny <fedor@indutny.com>
@indutny indutny closed this as completed Apr 23, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@indutny @KjellSchubert