Proxy default properties as well as named #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure who to request a review from, but @bengl I am familiar with you, so: tag, you're it. |
bengl
requested changes
Dec 8, 2023
| @@ -128,6 +128,9 @@ ${exportNames.map((n) => ` | |||
| let $${n} = namespace.${n} | |||
| export { $${n} as ${n} } | |||
| set.${n} = (v) => { | |||
| if ('${n}' !== 'default' && namespace.default['${n}']) { | |||
| namespace.default['${n}'] = v | |||
There was a problem hiding this comment.
I think you need to make sure that this only applies to CJS modules. This could easily be incorrect for ESM modules.
There was a problem hiding this comment.
Noted. I'm putting this PR on hold until we have resolution on my others. Even if this one were merged, I'd still have to proxy the returned proxy because I need a symbol to detect the proxy. So I want to write up a case for that and discuss it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to a discussion in Slack. As it is, IITM hooks will easily hook a "named" export from a CJS module but extra effort is required to hook the same exports that are defined on the "default" export. Prior to this PR, the lines 20 and 23 in the included test case will fail.