doc: copyedit benchmark/README.md #1970
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
doc
Trott
force-pushed
the
benchmark-copyedit
branch
from
fdebca0
to
8512333
Compare
|
|
||
| 1. Run all tests of a given type, for example, buffers | ||
| 1\. Run all tests of a given type, for example, buffers |
There was a problem hiding this comment.
These should probably just be sub-headers.. h3?
Trott
force-pushed
the
benchmark-copyedit
branch
from
8512333
to
c2058a6
Compare
|
Pushed new commit per feedback from @Fishrock123 changing list to headers |
Trott
force-pushed
the
benchmark-copyedit
branch
from
c2058a6
to
f2043d5
Compare
Trott
changed the title
|
Pinging the only people listed as collaborators who have commits on this file in the hopes of getting a quick "LGTM" or two: @Fishrock123 @jbergstroem @yosuke-furukawa |
|
LGTM |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jun 15, 2015
PR-URL: nodejs#1970 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
|
Merged in 5c2707c |
This was referenced Jun 22, 2023
This was referenced Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.