Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: copyedit benchmark/README.md #1970

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 13, 2015

No description provided.

@mscdex mscdex added doc Issues and PRs related to the documentations. benchmark Issues and PRs related to the benchmark subsystem. labels Jun 13, 2015

1. Run all tests of a given type, for example, buffers
1\. Run all tests of a given type, for example, buffers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should probably just be sub-headers.. h3?

@Trott
Copy link
Member Author

Trott commented Jun 13, 2015

Pushed new commit per feedback from @Fishrock123 changing list to headers

@Trott Trott changed the title doc: fix typo in benchmark/README.md doc: copyedit benchmark/README.md Jun 14, 2015
@Trott
Copy link
Member Author

Trott commented Jun 15, 2015

Pinging the only people listed as collaborators who have commits on this file in the hopes of getting a quick "LGTM" or two: @Fishrock123 @jbergstroem @yosuke-furukawa

@jbergstroem
Copy link
Member

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Jun 15, 2015
PR-URL: nodejs#1970
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@Trott
Copy link
Member Author

Trott commented Jun 15, 2015

Merged in 5c2707c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants