This repository has been archived by the owner on Nov 21, 2018. It is now read-only.
Refactors/simplify the “Templates” task in a more gulp-like way #257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open questions:
package.json
are no longer neededTo do (non-blockers):
Notes:
public/**/*.html
is the same, except for the removal of the build information. (The non-blockers above can land later.)Edit: I originally reported the refactor was (suspiciously) slower now than the original. But, in fact, because Gulp is reporting the original version of this task as completed near-instantly and not factoring in work which was is processing, this benchmark is incorrect.
On my modern MacBook Pro I'm getting about 1700ms less runtime with the refactor when manually benchmarking
gulp templates
with aprocess.on('exit', /* ... */)
hook shared between the two branches:To be fair, this refactor also does less work (no git log parsing, no checksum lookup/checks.)