Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llhttp 9.0.0 no longer accepts bare LF #236

Closed
guoye-zhang opened this issue Aug 3, 2023 · 3 comments · Fixed by #239
Closed

llhttp 9.0.0 no longer accepts bare LF #236

guoye-zhang opened this issue Aug 3, 2023 · 3 comments · Fixed by #239

Comments

@guoye-zhang
Copy link
Contributor

The following response is rejected by the parser even with all lenient flags enabled:

"HTTP/1.1 200 OK\nContent-Length: 0\n\n"

@ShogunPanda
Copy link
Contributor

I think this is an unwanted regression. I'll take a look soon.

@Dreamsorcerer
Copy link
Contributor

Which option will need to be enabled after the PR lands to enable this (had a couple of users report similar issues)?
llhttp_set_lenient_optional_lf_after_cr()?

@ShogunPanda
Copy link
Contributor

ShogunPanda commented Aug 9, 2023

You'll have to use llhttp_set_lenient_headers. The bug was not on the new flags but on old ones :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants