Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support all LF messages. #239

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Conversation

ShogunPanda
Copy link
Contributor

@ShogunPanda ShogunPanda commented Aug 7, 2023

Fixes #236.
Fixes #238.

@ShogunPanda ShogunPanda mentioned this pull request Aug 7, 2023
@ShogunPanda
Copy link
Contributor Author

@RafaelGSS @mcollina Any update on this? Can I merge it?

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShogunPanda ShogunPanda merged commit 72f5309 into nodejs:main Aug 21, 2023
@ShogunPanda ShogunPanda deleted the lf-regression branch August 21, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test mistake? llhttp 9.0.0 no longer accepts bare LF
3 participants