Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a __wasm__ define guard around public APIs #175

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Remove a __wasm__ define guard around public APIs #175

merged 1 commit into from
Aug 22, 2022

Conversation

rdw-software
Copy link
Contributor

Hi,

while writing LuaJIT bindings for this library I noticed something peculiar:

Accordingly, I'm unable to bind these functions (without hacks). This PR should fix the problem, hopefully without side effects.

Since I'm not sure about the wasm stuff I simply moved the define upwards instead of completely deleting it.

@ShogunPanda ShogunPanda self-requested a review August 22, 2022 14:44
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ShogunPanda ShogunPanda merged commit 2f9ec23 into nodejs:main Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants