Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed CMake integration. #226

Merged
merged 1 commit into from
Jul 4, 2023
Merged

fix: Fixed CMake integration. #226

merged 1 commit into from
Jul 4, 2023

Conversation

ShogunPanda
Copy link
Contributor

Fixes #222.

@ShogunPanda ShogunPanda mentioned this pull request Jun 14, 2023
Closed
mcollina
mcollina approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ShogunPanda ShogunPanda merged commit a0e744f into nodejs:main Jul 4, 2023
@ShogunPanda ShogunPanda deleted the fix-cmake branch July 4, 2023 09:45
@ShogunPanda ShogunPanda mentioned this pull request Sep 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Couldn't add llhttp as dependency with cmake
3 participants
@ShogunPanda @mcollina @RafaelGSS