Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not assume a particular sed implementation #230

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Do not assume a particular sed implementation #230

merged 1 commit into from
Jul 3, 2023

Conversation

musicinmybrain
Copy link
Contributor

Make the release target in the Makefile more portable.

See conversation: 7e18596#r119290262

@musicinmybrain
Do not assume a particular sed implementation
553ae7d 
Make the release target in the Makefile more portable.
@musicinmybrain
Copy link
Contributor Author

I haven’t tested this on MacOS / BSD-sed, but it fixes the issue I encountered with GNU-sed, and shouldn’t rely on any implementation details not specified by POSIX.

musicinmybrain referenced this pull request Jun 27, 2023
@ShogunPanda
fix: Do not allow empty header separated by CR. (#227)
7e18596
ShogunPanda
ShogunPanda approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing, thanks!

@ShogunPanda ShogunPanda merged commit 14d263c into nodejs:main Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShogunPanda ShogunPanda ShogunPanda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@musicinmybrain @ShogunPanda