-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Drop strict mode in favor of leniency flags. #234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
does this impact the benchmarks at all?
Nope, nothing at all. Before:
After (consider that the new mode is equivalent to the old strict mode):
Are we good to merge and release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's missing the breaking change label, right? Also, would be great to have a PR description so people can look at it when evaluating llhttp 9
For people coming from old http_parser it would be good to write steps how to migrate to llhttp if they used STRICT=OFF in cmake. |
This PR drops completely the strict mode in favor of three new leniency flags.