Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chunk extensions quoted-string value parsing #253

Merged

Conversation

ngrodzitski
Copy link
Contributor

According to rfc9112 quoted string is defined by rfc9110

quoted-string = <quoted-string, see [HTTP], Section 5.6.4>

The definition of quoted-string also uses a notion of quoted-pair:

quoted-pair    = "\" ( HTAB / SP / VCHAR / obs-text )

This change makes the parsing of quoted-string aware of quoted-pairs and makes it possile to handle valid quoted strings.

References:

According to [rfc9112](https://datatracker.ietf.org/doc/html/rfc9112) quoted string is defined
by [rfc9110](https://datatracker.ietf.org/doc/html/rfc9110)

```
quoted-string = <quoted-string, see [HTTP], Section 5.6.4>
```

The definition of quoted-string also uses a notion of quoted-pair:

```
quoted-pair    = "\" ( HTAB / SP / VCHAR / obs-text )
```

This change makes the parsing of quoted-string aware of quoted-pairs and makes it possile
to handle valid quoted strings.

References:

* https://datatracker.ietf.org/doc/html/rfc9112#name-syntax-notation
* https://datatracker.ietf.org/doc/html/rfc9112#name-chunk-extensions
* https://datatracker.ietf.org/doc/html/rfc9110#section-5.6.4
@ngrodzitski ngrodzitski force-pushed the fix/rfc9110-quoted-string-in-chunk-ext branch from b7e9bd2 to 8328f35 Compare October 1, 2023 21:23
@ShogunPanda ShogunPanda merged commit 5b57e4c into nodejs:main Oct 3, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants