Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Restart the parser on HTTP 100. #254

Merged
merged 1 commit into from
Oct 3, 2023
Merged

fix: Restart the parser on HTTP 100. #254

merged 1 commit into from
Oct 3, 2023

Conversation

ShogunPanda
Copy link
Contributor

Fixes #249.

@cdce8p
Copy link

cdce8p commented Oct 3, 2023

Awesome @ShogunPanda! Just tested it with aiohttp and it fixes the regressions 🎉
Just one failed test remaining, but that's only a slightly different error message so the regex doesn't match anymore.

@ShogunPanda
Copy link
Contributor Author

So it's on your side, isn't it?

@cdce8p
Copy link

cdce8p commented Oct 3, 2023

So it's on your side, isn't it?

Yeah. That can (and should) easily be fixed in the aiohttp test suite.

@ShogunPanda ShogunPanda merged commit a6e3cd8 into nodejs:main Oct 3, 2023
7 checks passed
@ShogunPanda ShogunPanda deleted the fix-249 branch October 3, 2023 15:03
@Dreamsorcerer
Copy link
Contributor

Yep, I've already updated locally, just need to grab the new llhttp, then everything should be passing.

@massongit massongit mentioned this pull request Oct 7, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

9.1.0 regression: doesn't parse message following 100 response
3 participants
@ShogunPanda @cdce8p @Dreamsorcerer