Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: repair build-wasm npm script #277

Merged
merged 4 commits into from
Jan 30, 2024
Merged

fix: repair build-wasm npm script #277

merged 4 commits into from
Jan 30, 2024

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Jan 29, 2024

while trying to improve llhttp for undici, it showed that building wasm is broken in main due to typescript typings issues.
This PR fixes them, so that we can run npm run build-wasm

@Uzlopak Uzlopak changed the title fix: repair build wasm npm script fix: repair build-wasm npm script Jan 29, 2024
ShogunPanda
ShogunPanda requested changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would avoid having any here. What about Error or, if it is lacking code, something like type ErrorWithCode = Error & { code: string }?

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Jan 30, 2024

@ShogunPanda
added a typeguard.

ShogunPanda
ShogunPanda approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Jan 30, 2024

@ShogunPanda
the linting issue will be fixed in #278 and vice versa

@Uzlopak Uzlopak mentioned this pull request Jan 30, 2024
Merged
@ShogunPanda ShogunPanda merged commit 64de8f1 into nodejs:main Jan 30, 2024
10 of 11 checks passed
@Uzlopak Uzlopak deleted the fix-build-wasm branch January 30, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShogunPanda ShogunPanda ShogunPanda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Uzlopak @ShogunPanda