Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace tslint with eslint and stylistic #279

Merged
merged 5 commits into from
Jan 30, 2024
Merged

Replace tslint with eslint and stylistic #279

merged 5 commits into from
Jan 30, 2024

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Jan 30, 2024

one linting issue remains, but should be resolved if #278 is merged.

ShogunPanda
ShogunPanda approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing!

@ShogunPanda ShogunPanda merged commit 32f05c1 into nodejs:main Jan 30, 2024
10 of 11 checks passed
@Uzlopak Uzlopak deleted the replace-tslint-with-eslint branch January 30, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShogunPanda ShogunPanda ShogunPanda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Uzlopak @ShogunPanda