Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use clean installs from MPN #298

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Use clean installs from MPN #298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/aiohttp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
key: ubuntu-latest-node-${{ hashFiles('vendor/llhttp/**/package-lock.json') }}
restore-keys: ubuntu-latest-node-
- name: Install llhttp dependencies
run: npm install --ignore-scripts
run: npm ci --ignore-scripts
working-directory: vendor/llhttp
- name: Build llhttp
run: make
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
${{ runner.os }}-node-

- name: Install dependencies
run: npm install --ignore-scripts
run: npm ci --ignore-scripts

- name: Build libllhttp.a
shell: bash
Expand Down Expand Up @@ -88,7 +88,7 @@ jobs:
${{ runner.os }}-node-

- name: Install dependencies
run: npm install --ignore-scripts
run: npm ci --ignore-scripts

# Custom script, because progress looks not good in CI
- name: Run tests
Expand All @@ -112,7 +112,7 @@ jobs:
${{ runner.os }}-node-

- name: Install dependencies
run: npm install --ignore-scripts
run: npm ci --ignore-scripts

- name: Run lint command
run: npm run lint
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ With this flag this check is disabled.
Make sure you have [Node.js](https://nodejs.org/), npm and npx installed. Then under project directory run:

```sh
npm install
npm ci
make
```

Expand Down Expand Up @@ -451,7 +451,7 @@ _Note that using the git repo directly (e.g., via a git repo url and tag) will n

1. Ensure that `Clang` and `make` are in your system path.
2. Using Git Bash, clone the repo to your preferred location.
3. Cd into the cloned directory and run `npm install`
3. Cd into the cloned directory and run `npm ci`
5. Run `make`
6. Your `repo/build` directory should now have `libllhttp.a` and `libllhttp.so` static and dynamic libraries.
7. When building your executable, you can link to these libraries. Make sure to set the build folder as an include path when building so you can reference the declarations in `repo/build/llhttp.h`.
Expand Down
Loading