-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - test: Fix the path to llnode plugin #111
Conversation
Load the llnode plugin from the location npm install creates it at.
This fix causes This gets the test code running on travis but the tests are still failing: |
Would it make sense to try to detect the location in |
@cjihrig - It might do, there's not that many places to look. I guess the problem is which to pick if both are found. (That could just result in a test failure that reminds you to delete one of them though!) |
We could emit a warning or complain loudly in some other way if they are both found. |
Slightly awkwardly the travis build runs npm install which builds the plugin then runs the _travis make target which runs gyp_llnode and compiles the plugin. This change blocks all the tests running on travis: I'll figure out what to do next, I have to push the changes to a branch on a PR so that travis picks them up though so I've added a WIP tag to this PR! |
Travis is now working with the plugin built with |
Ping @hhellyer. Can you update or close? |
I'll close, it's been a bit too long since I looked at this and I'm not in a position to update it at the moment. Sorry for leaving it lying around! |
Load the llnode plugin from the location npm install creates it at.