Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: inspcet arguments from an Error object stack #271

Closed

Conversation

mmarchini
Copy link
Contributor

This is useful when the process aborts later than a thrown error (for
example, when there's an async rethrow or an unhandled Promise
rejection). V8 changes to make this possible landed in
v8/v8@3724a125.

This is useful when the process aborts later than a thrown error (for
example, when there's an async rethrow or an unhandled Promise
rejection). V8 changes to make this possible landed in
v8/v8@3724a125.
@mmarchini
Copy link
Contributor Author

Still need to add some tests here. Also, there's no way to test this feature with current Node.js release lines, so we might want to wait to land it.

@cjihrig
Copy link
Contributor

cjihrig commented Feb 26, 2019

Typo in the commit message: inspcet -> inspect

@mmarchini
Copy link
Contributor Author

Recent-ish changes on V8 rendered this feature less useful (it's less likely users will get an Error object with the raw stack we expect), so I'm closing it for now. We can revisit it if situation changes.

@mmarchini mmarchini closed this Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants