Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nodejs v12 support #330

Closed
wants to merge 9 commits into from
Closed

Nodejs v12 support #330

wants to merge 9 commits into from

Commits on Jan 16, 2020

  1. src: v12.x-compatible DescriptorArray 

    V8 changed DescriptorArray from a FixedArray to a proper HeapObject.
These changes update accessors for DescriptorArray fields to make them
compatible with FixedArray-like and HeapObject-like access.

Ref: nodejs#255
    @mmarchini
    mmarchini committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    b2e6346 View commit details
    Browse the repository at this point in the history

  2. test: skip inferredName on 12 

    V8 changed the function name inference algorithm, which affected one of
our test cases. Even if it's reverted/fixed upstream, it won't make it's
way into v12, so skip that particular test for this version.

Ref: https://bugs.chromium.org/p/v8/issues/detail?id=9807
    @mmarchini
    mmarchini committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    8d9d9dd View commit details
    Browse the repository at this point in the history

  3. src: v12 fixed for JSArrayBuffer & FixedTypedArray

    @mmarchini
    mmarchini committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    b164bff View commit details
    Browse the repository at this point in the history

  4. src: handle String__FIELD_offset__int 

    Some Node.js v12 versions will have String postmortem metadata as
`String__FIELD_offset__int` instead of `String__FIELD_offset__TYPE`.
Handle both cases so llnode can work on more versions.
    @mmarchini
    mmarchini committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    8491953 View commit details
    Browse the repository at this point in the history

  5. src: make Symbol more resilient 

    Instead of crashing if llnode fails to parse a Symbol, just return  a
??? token.
    @mmarchini
    mmarchini committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    ece9589 View commit details
    Browse the repository at this point in the history

  6. src: use 24 as default for kHeaderSize

    @mmarchini
    mmarchini committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    dec5479 View commit details
    Browse the repository at this point in the history

  7. src: guess Symbol.name offset

    @mmarchini
    mmarchini committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    2d21dc8 View commit details
    Browse the repository at this point in the history

  8. build: update Node.js versions on CI matrix

    @mmarchini
    mmarchini committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    94f2de0 View commit details
    Browse the repository at this point in the history

  9. 3.0.0

    @mmarchini
    mmarchini committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    dd863a3 View commit details
    Browse the repository at this point in the history