-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation warnings #374
Open
amdoku
wants to merge
8
commits into
nodejs:main
Choose a base branch
from
amdoku:compilation-warnings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Compilation warnings #374
Commits on Oct 3, 2020
-
src:fix non-void function not return in a value
When compiling with gcc-10.2.0 this would emit a warning
Configuration menu - View commit details
-
Copy full SHA for c4d1405 - Browse repository at this point
Copy the full SHA c4d1405View commit details -
src:fix warning use reference type to prevent copy
When compiling under gcc-10.2.0 this line would emit a warning
Configuration menu - View commit details
-
Copy full SHA for e2594c5 - Browse repository at this point
Copy the full SHA e2594c5View commit details -
src: Fix signed-unsigned comparison in printer.cc
When compiling under gcc-10.2.0 this would emit a warning
Configuration menu - View commit details
-
Copy full SHA for 14728f6 - Browse repository at this point
Copy the full SHA 14728f6View commit details -
src: Remove warning about (malformed) trigraph
When compiling under gcc-10.2.0 this would emit a warning By escaping the '?' it will no longer be detected as a trigraph.
Configuration menu - View commit details
-
Copy full SHA for c66fcaf - Browse repository at this point
Copy the full SHA c66fcafView commit details -
When compiling all warnings will now be treated as an error, preventing potentially misbehaving code from making it onto master.
Configuration menu - View commit details
-
Copy full SHA for a054621 - Browse repository at this point
Copy the full SHA a054621View commit details -
When executing tests with gdb-9.2 and lldb-10.0.1 the tests would fail. Relaxing the error assertion to only check for the warning itself, not the location fixes the test.
Configuration menu - View commit details
-
Copy full SHA for 891890c - Browse repository at this point
Copy the full SHA 891890cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1cc7105 - Browse repository at this point
Copy the full SHA 1cc7105View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9030cd7 - Browse repository at this point
Copy the full SHA 9030cd7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.