This repository has been archived by the owner on Sep 2, 2023. It is now read-only.
Governance: "Pull Requests" post Phase 2 upstream #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMotaal
changed the title
SMotaal
requested review from
Fishrock123,
MylesBorins,
bmeck and
GeoffreyBooth
added 2 commits
April 10, 2019 16:23
SMotaal
added
doc
governance
modules-agenda
MylesBorins
previously requested changes
Apr 16, 2019
|
@SMotaal I've gone ahead and pushed 2 commits to fix the notes I suggested. Feel free to revert or make more changes. I'm going to dismiss my review but hold off on LGTM until we have consensus around changes. |
|
|
||
| These expectations are intended to ensure that all concurrent efforts align | ||
| with the overall direction of the group for delivering a cohesive and predictable | ||
| user experience for ECMAScript, CommonJS, and other modules supported by Node.js. |
There was a problem hiding this comment.
What's really changing here? From a policy perspective.
There was a problem hiding this comment.
The biggest change should be the removal of the moratorium
There was a problem hiding this comment.
I'm not sure I am following… Can you suggest or clarify what I can do here?
There was a problem hiding this comment.
I don't think anything else needs to be done personally
mihalskiy
approved these changes
Apr 23, 2019
jdalton
approved these changes
Apr 24, 2019
jkrems
approved these changes
Apr 24, 2019
GeoffreyBooth
approved these changes
Apr 24, 2019
robpalme
approved these changes
Apr 24, 2019
Fishrock123
approved these changes
Apr 24, 2019
ljharb
approved these changes
Apr 24, 2019
targos
approved these changes
Apr 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the governance doc to reflect what was discussed in the prior meeting #302.
The previous heading which "Merging PRs into this Repository or nodejs/ecmascript-modules" has been replaced with a "Pull Requests" and broken down into:
This new structure is my best effort to adhere to the existing wording and still be able to detail the general discussion points based on the minutes and the recording. Please note that I found it rather difficult to distill all this and greatly welcome your help improving on this before landing.