Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8 4.4 to remove indexed properties via external data #316

Closed
kkoopa opened this issue Apr 18, 2015 · 6 comments
Closed

V8 4.4 to remove indexed properties via external data #316

kkoopa opened this issue Apr 18, 2015 · 6 comments
Milestone

Comments

@kkoopa
Copy link
Collaborator

kkoopa commented Apr 18, 2015

nodejs/node#1451

How to solve this in NAN?

@kkoopa
Copy link
Collaborator Author

kkoopa commented Apr 19, 2015

What about updating https://github.com/joyent/node/blob/v0.10.38/src/v8_typed_array.cc to conform with the final spec and creating wrapper functions that use this for old versions and v8's own implementation for new versions?

@kkoopa kkoopa added this to the 2.0 milestone May 8, 2015
@kkoopa
Copy link
Collaborator Author

kkoopa commented May 22, 2015

@trevnorris What's the status of Buffer for io.js 3.0? Do you have anything that works with nodejs/next? Have you settled on an external API? What's what? The new Buffer API is the only major thing holding off NAN 2.0.

@trevnorris
Copy link
Collaborator

@kkoopa I don't have an implementation complete, but my preliminary research shows that we should be able to keep the current C++ Buffer implementation as it is. Despite all the internal changes that we'll have to make. There is one difference in that there will no longer exist the upper limit of 0x3fffffff starting with 4.4 IIRC. But that shouldn't pose any problem.

Maintaining the same JS API has yet to be determined, but I don't believe that affects this.

@kkoopa
Copy link
Collaborator Author

kkoopa commented May 23, 2015

OK, that's good, I think. I don't care about the JS API. The question remains whether to backport typed arrays or not. Buffer should suffice, shouldn't it? That would mean addons neither set external array data nor use typed arrays. Does Buffer handle all those cases efficiently?

@trevnorris
Copy link
Collaborator

@kkoopa Buffer does contain all the necessary APIs to create objects with a backing store of external memory. Either new, or from an existing allocation. So you shouldn't need to backport either the external array data or the array buffer APIs.

@kkoopa
Copy link
Collaborator Author

kkoopa commented May 24, 2015

That is very good. Less work for me. Then I'll close this issue, as there is nothing left to do.

@kkoopa kkoopa closed this as completed May 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants