Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support joyent/node 0.11.15 #259

Merged
merged 1 commit into from
Jan 21, 2015
Merged

Support joyent/node 0.11.15 #259

merged 1 commit into from
Jan 21, 2015

Conversation

kkoopa
Copy link
Collaborator

@kkoopa kkoopa commented Jan 21, 2015

Scheduled for 1.6.0.

@bnoordhuis
Copy link
Member

LGTM but I would keep the comment.

@kkoopa
Copy link
Collaborator Author

kkoopa commented Jan 21, 2015

Yes, I readded the comment.

@kkoopa kkoopa deleted the joyent branch January 21, 2015 12:01
@bnoordhuis
Copy link
Member

@kkoopa You should back-port this to the v1.4 branch.

@bnoordhuis
Copy link
Member

Or maybe not... NanSetCounterFunction() is new in v1.5.

@kkoopa
Copy link
Collaborator Author

kkoopa commented Jan 21, 2015

Really? It's quite many new additions.

Yes, I think 1.6 is the right version.

1.5 had the NanNew rewrite, will push out one more patch release of that with bugfixes, as soon as #248 has landed.

As soon as that is done, I will push 1.6.0, which will introduce support for joyent/node 0.11.15, hopefully will work with atom-shell, and also have the new Encode/Decode functions.

@kkoopa
Copy link
Collaborator Author

kkoopa commented Jan 21, 2015

Actually, I think 1.4 or 1.5 should work on 0.11.15. The moved utility function wrappers were omitted from 1.5.0 due to time constraints. As long as you don't need them, either version is fine to use.

The wrappers will be in 1.6.0, which is still unreleased. Both joyent/0.11.15 and iojs/1.0.0 require the wrappers if said utility functions are used.

In summary: 1.6 is the only branch that needs this.

@drewish
Copy link

drewish commented Feb 23, 2015

Will this work with nw.js?

Update: Asking because justinlatimer/node-midi#63 (comment) made me this this isn't available there.

@kkoopa
Copy link
Collaborator Author

kkoopa commented Feb 24, 2015

It should work with some version of nw.js, but I don't know for sure.
#285 might be related.

@kkoopa
Copy link
Collaborator Author

kkoopa commented Feb 24, 2015

The problem lies entirely with nw.js, which lies about every version imaginable. This is unmanageable.

@rogerwang
Copy link
Member

@kkoopa why did you say nw.js lies about the version? Please give more details -- we'd like to fix any potential issues at our side and make things smooth for other projects including Nan.

@kkoopa
Copy link
Collaborator Author

kkoopa commented Feb 24, 2015

Because nw-headers-v0.11.6.tar.gz states that it is node 0.11.13 in node-version.h, when the actual node 0.11.13 came with a different v8 version. There is no way of telling that this is not normal node 0.11.13.

@rogerwang
Copy link
Member

The discussion on NW.js moved to #285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants