-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support joyent/node 0.11.15 #259
Conversation
LGTM but I would keep the comment. |
Yes, I readded the comment. |
@kkoopa You should back-port this to the v1.4 branch. |
Or maybe not... NanSetCounterFunction() is new in v1.5. |
Really? It's quite many new additions. Yes, I think 1.6 is the right version. 1.5 had the As soon as that is done, I will push 1.6.0, which will introduce support for joyent/node 0.11.15, hopefully will work with atom-shell, and also have the new Encode/Decode functions. |
Actually, I think 1.4 or 1.5 should work on 0.11.15. The moved utility function wrappers were omitted from 1.5.0 due to time constraints. As long as you don't need them, either version is fine to use. The wrappers will be in 1.6.0, which is still unreleased. Both joyent/0.11.15 and iojs/1.0.0 require the wrappers if said utility functions are used. In summary: 1.6 is the only branch that needs this. |
Will this work with nw.js? Update: Asking because justinlatimer/node-midi#63 (comment) made me this this isn't available there. |
It should work with some version of nw.js, but I don't know for sure. |
The problem lies entirely with nw.js, which lies about every version imaginable. This is unmanageable. |
@kkoopa why did you say nw.js lies about the version? Please give more details -- we'd like to fix any potential issues at our side and make things smooth for other projects including Nan. |
Because nw-headers-v0.11.6.tar.gz states that it is node 0.11.13 in node-version.h, when the actual node 0.11.13 came with a different v8 version. There is no way of telling that this is not normal node 0.11.13. |
The discussion on NW.js moved to #285 |
Scheduled for 1.6.0.