Add context awareness to Nan::AsyncWorker and Nan::Callback #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Also some cleanup * avoid unused private field warning on old node versions * no reason to have async_context as a concept * avoids camelCase for field asyncContext less camel, less case
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Is this ready to merge now? |
|
All good from my side.
…On Mon, Feb 12, 2018, 6:04 PM Benjamin Byholm ***@***.***> wrote:
Is this ready to merge now?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#731 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAE0qRD3fI9cLSQ0uf5JC9Cztm14Zv7Iks5tUMOVgaJpZM4R_Say>
.
|
|
Thanks everybody. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three commits here. Each can be individually reviewed.
Background: nodejs/node#13254.
Continuing on from #729, this adds async context support to Nan::Callback and Nan::AsyncWorker (and subclasses).
I have not added any deprecations to the legacy
Nan::Callback::Calls versions yet. I propose to do that in the next PR.