Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add windows test support to Travis #853

Closed
wants to merge 1 commit into from

Conversation

msimerson
Copy link

This is test PR, adding windows build support to Travis. It's an alternative for #850 to waiting for appveyor support. IME, Travis windows builds are a fair bit slower than appveyor, but I've also had plenty of false positives on appveyor tests, so it's a mixed bag.

This PR should kick off a Travis build and we can see if it works or not.

This is test PR, adding windows build support to Travis. It's an alternative for nodejs#850 to waiting for appveyor support.  IME, Travis windows builds are a fair bit slower than appveyor, but I've also had plenty of false positives on appveyor tests, so it's a mixed bag.
@msimerson
Copy link
Author

the builds fail on Travis windows. I don't have the time or inclination to track it down. Someone that has an interest in this though could try running a shell script instead of the series of CLIs, and then add a custom path for building on Travis Windows.

Autoclose me in 30 days, if no progress.

@msimerson msimerson mentioned this pull request May 2, 2019
@bnoordhuis
Copy link
Member

nvm doesn't support Windows and has no plans to do so (ref) so I'm not surprised it doesn't work out of the box. nvm-windows will probably get you further although you probably also need to clean up the build rules.

I'll close this out for now but let me know if you want to continue working on it.

@bnoordhuis bnoordhuis closed this May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants