Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for DataView feature #196

Closed
romandev opened this issue Nov 29, 2017 · 5 comments
Closed

Add support for DataView feature #196

romandev opened this issue Nov 29, 2017 · 5 comments

Comments

@romandev
Copy link
Contributor

DataView objects provide an array-like view over an underlying data buffer, but one which allows items of different size and type in the ArrayBuffer.

So, we should provide wrapper implementation for the following APIs.

  • napi_is_dataview() [1]
  • napi_create_dataview() [2]
  • napi_get_dataview_info() [3]

[1] https://nodejs.org/dist/latest-v8.x/docs/api/n-api.html#n_api_napi_is_dataview
[2] https://nodejs.org/dist/latest-v8.x/docs/api/n-api.html#n_api_napi_create_dataview
[3] https://nodejs.org/dist/latest-v8.x/docs/api/n-api.html#n_api_napi_get_dataview_info
@romandev
Copy link
Contributor Author

@mhdawson Can I start to work on this? or If we need discussions or agreements, where can I see the process for adding these new APIs?

@mhdawson
Copy link
Member

Sounds good. We should have coverage for all of the things you can do in the core N-API.

@romandev
Copy link
Contributor Author

Okay, I'll take this :)

romandev added a commit to romandev/node-addon-api that referenced this issue Dec 11, 2017
@romandev
Implement Value.isDataView()
df5e70b 
The method is to check if the given value is a data view object. This ia
an initial implementation of DataView feature(nodejs#196).

This change also adds the NAPI_DATA_VIEW_FEATURE flag to expose only to
test modules until all features are implemented.
@romandev romandev mentioned this issue Dec 11, 2017
Closed
mhdawson pushed a commit that referenced this issue Dec 14, 2017
@romandev @mhdawson
Implement Value.isDataView()
b47cce8 
The method is to check if the given value is a data view object. This ia
an initial implementation of DataView feature(#196).

This change also adds the NAPI_DATA_VIEW_FEATURE flag to expose only to
test modules until all features are implemented.

PR-URL: #202
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
@NickNaso
Copy link
Member

NickNaso commented Sep 3, 2018

Hi @romandev,
what do you think? Could be possible close the issue?

romandev added a commit to romandev/node-addon-api that referenced this issue Sep 6, 2018
@romandev
Enable DataView feature by default
384a4a2 
This patch contains the following things:
  - Add a document for `DataView` feature
  - Remove NAPI_DATA_VIEW_FEATURE

Refs: nodejs#196
@romandev romandev mentioned this issue Sep 6, 2018
Closed
romandev added a commit to romandev/node-addon-api that referenced this issue Sep 6, 2018
@romandev
Enable DataView feature by default
ec90860 
This patch contains the following things:
  - Add a document for `DataView` feature
  - Remove NAPI_DATA_VIEW_FEATURE

Refs: nodejs#196
romandev added a commit to romandev/node-addon-api that referenced this issue Sep 6, 2018
@romandev
Enable DataView feature by default
a65c4b2 
This patch contains the following things:
  - Add a document for `DataView` feature
  - Remove NAPI_DATA_VIEW_FEATURE

Refs: nodejs#196
mhdawson pushed a commit that referenced this issue Sep 18, 2018
@romandev @mhdawson
src: enable DataView feature by default
b6e2d92 
This patch contains the following things:
  - Add a document for `DataView` feature
  - Remove NAPI_DATA_VIEW_FEATURE

Refs: #196

PR-URL: #331
Refs: #196
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
@NickNaso
Copy link
Member

@romandev
I think that now that #331* is landed we can close the issue.
Good work!

kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this issue Aug 24, 2022
@kevindavies8
src: enable DataView feature by default
3d87554 
This patch contains the following things:
  - Add a document for `DataView` feature
  - Remove NAPI_DATA_VIEW_FEATURE

Refs: nodejs/node-addon-api#196

PR-URL: nodejs/node-addon-api#331
Refs: nodejs/node-addon-api#196
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this issue Aug 26, 2022
@Marlyfleitas
src: enable DataView feature by default
d5aa952 
This patch contains the following things:
  - Add a document for `DataView` feature
  - Remove NAPI_DATA_VIEW_FEATURE

Refs: nodejs/node-addon-api#196

PR-URL: nodejs/node-addon-api#331
Refs: nodejs/node-addon-api#196
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this issue Sep 19, 2022
@wroy7860
src: enable DataView feature by default
f8513b1 
This patch contains the following things:
  - Add a document for `DataView` feature
  - Remove NAPI_DATA_VIEW_FEATURE

Refs: nodejs/node-addon-api#196

PR-URL: nodejs/node-addon-api#331
Refs: nodejs/node-addon-api#196
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this issue Aug 11, 2023
src: enable DataView feature by default
83ba6a5 
This patch contains the following things:
  - Add a document for `DataView` feature
  - Remove NAPI_DATA_VIEW_FEATURE

Refs: nodejs/node-addon-api#196

PR-URL: nodejs/node-addon-api#331
Refs: nodejs/node-addon-api#196
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NickNaso @romandev @mhdawson