Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] tests coverage for base error class #960

Closed
JckXia opened this issue Apr 2, 2021 · 5 comments
Closed

[Tests] tests coverage for base error class #960

JckXia opened this issue Apr 2, 2021 · 5 comments
Labels
good first issue never-stale test

Comments

@JckXia
Copy link
Member

JckXia commented Apr 2, 2021 •
edited
Loading

class methods
Covered (#621) static Error New(Napi::Env env)
Napi::Error()
Napi::Error(napi_env env, napi_value value)
Error::New(Napi::Env env, const char * message)
Covered (#24) Error::New(Napi::Env env, const std::string& message)
Covered(#621) Error::Fatal(const char * location, const char * message)
Error(Error&& other)
Error& operator =(Error&& other)
Error(const Error&)
Error& operator =(Error&)
const char* what() const NAPI_NOEXCEPT override
Covered(#52) const std::string& Message() const NAPI_NOEXCEPT
Covered(#52) void ThrowAsJavaScriptException() const
@NickNaso NickNaso added the test label Apr 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2021

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Jul 2, 2021
@NickNaso NickNaso removed the stale label Jul 2, 2021
@github-actions
Copy link
Contributor

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Jan 13, 2022
@NickNaso NickNaso removed the stale label Jan 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2022

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label May 6, 2022
@NickNaso NickNaso removed the stale label May 6, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added stale and removed stale labels Nov 12, 2022
@JckXia JckXia mentioned this issue Mar 9, 2023
Closed
@JckXia
Copy link
Member Author

JckXia commented Mar 23, 2023

Marked as complete following #1295

@JckXia JckXia closed this as completed Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue never-stale test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add test coverage for Error class JckXia/node-addon-api
2 participants
@NickNaso @JckXia