Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for Error class #1295

Closed
wants to merge 3 commits into from
Closed

Conversation

JckXia
Copy link
Member

@JckXia JckXia commented Mar 9, 2023

Closes #960

@JckXia JckXia added the test label Mar 9, 2023
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson pushed a commit that referenced this pull request Mar 22, 2023
PR-URL: #1295
Reviewed-By: Michael Dawson <midawson@redhat.com
@mhdawson
Copy link
Member

Landed in a8ad7e7

@mhdawson mhdawson closed this Mar 22, 2023
@JckXia JckXia deleted the base-error-tests branch March 23, 2023 13:42
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
PR-URL: nodejs/node-addon-api#1295
Reviewed-By: Michael Dawson <midawson@redhat.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tests] tests coverage for base error class
2 participants