Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add test coverage for Data() class method of underlying TypedArrayOf class #1203

Closed
wants to merge 4 commits into from

Conversation

JckXia
Copy link
Member

@JckXia JckXia commented Sep 6, 2022

Add test coverage to ensure the Data() method of the underlying TypedArrayOf returns the correct data

@JckXia JckXia changed the title Add typed array of tests test: Add test coverage for Data() class method of underlying TypedArrayOf class Sep 6, 2022
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson pushed a commit that referenced this pull request Sep 20, 2022
- add tests for .Data method to ensure the content is consistent

PR-URL: #1203
Reviewed-By: Michael Dawson <midawson@redhat.com
@mhdawson
Copy link
Member

Landed as 30cd4a3

@mhdawson mhdawson closed this Sep 20, 2022
@JckXia JckXia deleted the add-typed-array-of-tests branch December 14, 2022 00:46
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
- add tests for .Data method to ensure the content is consistent

PR-URL: nodejs/node-addon-api#1203
Reviewed-By: Michael Dawson <midawson@redhat.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants