Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not include component name in tag #1538

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Jul 12, 2024

By default release-please creates a tag with component names: https://github.com/googleapis/release-please/blob/main/docs/manifest-releaser.md#subsequent-versions

There is only one component in the repo so there is no need to include component name in tag name.

Refs: https://github.com/nodejs/node-addon-api/releases/tag/node-addon-api-v8.1.0

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.69%. Comparing base (bc5acef) to head (9faadec).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1538   +/-   ##
=======================================
  Coverage   64.69%   64.69%           
=======================================
  Files           3        3           
  Lines        1997     1997           
  Branches      687      687           
=======================================
  Hits         1292     1292           
  Misses        144      144           
  Partials      561      561           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit 12ffe91 into nodejs:main Jul 12, 2024
36 checks passed
@legendecas legendecas deleted the release-please-config branch July 12, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants