src: return bool on object set and define property #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If c++ exception is disabled, there is no ergonomic way to detect failtures on void returning.
1 task
|
@nodejs/node-api it will be great for this PR to have reviews, thanks a lot :D |
KevinEady
approved these changes
Apr 27, 2021
There was a problem hiding this comment.
Hi @legendecas , just a clarification that changing return type from void to bool is not breaking, correct....? I don't see it as a problem, but perhaps there is something I am missing...
|
@KevinEady yes, this is not a breaking change. Existing code will continue to compile and works (and there are still lots of them in the test suites), like https://github.com/nodejs/node-addon-api/blob/main/test/binding.cc#L76. |
deepakrkris
pushed a commit
to deepakrkris/node-addon-api
that referenced
this pull request
Sep 23, 2021
If c++ exception is disabled, there is no ergonomic way to detect failtures on void returning.
deepakrkris
pushed a commit
to deepakrkris/node-addon-api
that referenced
this pull request
Oct 15, 2021
If c++ exception is disabled, there is no ergonomic way to detect failtures on void returning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If c++ exception is disabled, there is no ergonomic way to detect
failtures on void returning.