Build with cmake #113
Merged
Build with cmake #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickNaso
reviewed
Sep 18, 2019
gabrielschulhof
approved these changes
Sep 23, 2019
mhdawson
approved these changes
Sep 23, 2019
|
PR merged as discussed during today's N-API team weekly meeting. |
|
Arrg! I'm creating a new PR to implement Gabriel's requests. It should be up momentarily. |
|
I am tracking down why the identical build that succeeded three days ago is now failing. Once I have that issue resolved, I'll create a new PR that fixes the build and adds Gabriel's requests. 2019-09-20 https://travis-ci.org/jschlight/node-addon-examples/builds/587656587 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created a couple of example projects that show how to build N-API addons using CMake.js. Once this PR lands, I plan to add links to it, along with some narrative, to nodejs/abi-stable-node#381 and nodejs/node-addon-api#445.