Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

test: update .gitignore with .DS_Store for macOS #363

Closed
wants to merge 1 commit into from
Closed

test: update .gitignore with .DS_Store for macOS #363

wants to merge 1 commit into from

Conversation

tommyZZM
Copy link

@tommyZZM tommyZZM commented Aug 9, 2017

Checklist
Affected core subsystem(s)

no

fix flowing not Untracked files message on git status

node-chakracore$ git status
On branch master
Your branch is up-to-date with 'origin/master'.
Untracked files:
  (use "git add <file>..." to include in what will be committed

        .DS_Store
	chakrashim/.DS_Store
	npm/.DS_Store
	openssl/.DS_Store
	openssl/openssl/.DS_Store
	v8/.DS_Store
	v8/test/.DS_Store
	v8/test/mjsunit/.DS_Store
	../tools/eslint/.DS_Store
	../tools/eslint/node_modules/.DS_Store

@kfarnung
Copy link
Contributor

kfarnung commented Aug 9, 2017

@tommyZZM Thanks for your contribution! I'm wondering if this is something that would be good to do upstream in nodejs/node and then it will merge into here.

/cc @kunalspathak

@kunalspathak
Copy link
Member

I agree with @kfarnung . This should be made in upstream first.

@kfarnung
Copy link
Contributor

kfarnung commented Aug 9, 2017

Created an upstream PR using @tommyZZM change.

nodejs/node#14721

@kfarnung
Copy link
Contributor

kfarnung commented Aug 9, 2017

@tommyZZM, please continue the discussion over at nodejs/node#14721.

@kfarnung kfarnung closed this Aug 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants