This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
chakrashim: Fix SetAccessorProperty behavior
#454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed some lint issues. Rerun CI: https://ci.nodejs.org/job/chakracore-test-pull-request/189/ Known issues:
|
PR-URL: nodejs#454 Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
`FunctionTemplate` asserts that it can get the external data from the provided object. The assert was hitting because the caller was passing in an empty `Local<FunctionTemplate>` object. PR-URL: nodejs#454 Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
kfarnung
added a commit
that referenced
this pull request
Jan 26, 2018
`FunctionTemplate` asserts that it can get the external data from the provided object. The assert was hitting because the caller was passing in an empty `Local<FunctionTemplate>` object. PR-URL: #454 Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 6, 2018
PR-URL: nodejs#454 Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 6, 2018
PR-URL: nodejs#454 Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 6, 2018
PR-URL: nodejs#454 Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 6, 2018
PR-URL: nodejs#454 Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 6, 2018
PR-URL: nodejs#454 Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 7, 2018
PR-URL: nodejs#454 Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FunctionTemplateasserts that it can get the external data from theprovided object. The assert was hitting because the caller was passing
in an empty
Local<FunctionTemplate>object.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
chakrashim