This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
Fixed various bugs around Error object #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI - @nodejs/node-chakracore |
| var splittedStack = stack.split('\n'); | ||
| splittedStack.splice(0, skipDepth + 1); // also skip top name/message line | ||
| var errstack = []; | ||
|
|
||
| for (var i = 0; i < splittedStack.length; i++) { | ||
| var parens = /\(/.exec(splittedStack[i]); |
There was a problem hiding this comment.
OT: given that parens is only used for its index, wouldn't splittedStack[i].indexOf('(') be more desirable?
There was a problem hiding this comment.
We could, but we need parens to get the index down, so just reused parens instead.
| var errstack = []; | ||
|
|
||
| for (var i = 0; i < splittedStack.length; i++) { | ||
| var parens = /\(/.exec(splittedStack[i]); | ||
| var funcName = splittedStack[i].substr(6, parens.index - 7); | ||
| var stackDetails = reStackDetails.exec(splittedStack[i]); |
There was a problem hiding this comment.
Could this line move down so that it won't run when skipDepth > 0?
|
LGTM 👍 |
1. We parse error stack in chakra_shim to make it simliar to that of v8. However we were missing the case if stack messages has `\n`. Fixed it. Fixes: nodejs#78 2. Fixed Error.captureStackTrace Since `chakra_shim.js` that patches `Error.captureStackTrace` runs under strict mode, it was not able to get caller information. Having caller information is much reliable in captureStackTrace than matching using `function.name`. Removed `use strict` and disabled eslint rule for `use strict`. This helped in matching caller exactly regardless of name of form `o.p.q` in `Error.captureStackTrace`. Fixes: nodejs#75 3. Added missing functions on StackFrame Added following missing methods on StackFrame: * getFunction * getMethodName * getTypeName * isConstructor * isToplevel * isNative Implemented `getFunction`. `getFunction` currently works if `.stack` is called from same callsite where `new Error()` or `Error.captureStackTrace()` was called. However currently we don't record and store the callstack when these functions were called and so we lose the information of `.caller` when called later while populating `e.stack`. If we save the callstack, we would be holding references to all the functions in the callstack which doesn't seem right. I have added a TODO to solve this, but wanted to send this out so we get better coverage on node compatibility. Fixes : nodejs#70 PR-URL: nodejs#85 Reviewed-By: Jianchun Xu <Jianchun.Xu@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX) orvcbuild test nosign(Windows) passesAffected core subsystem(s)
chakrashim
Description of change
Fixed various bugs around Error object. Individual commits has description.
Fixes: #70 , #75, #78