make file structure closer to Node.js' #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having the file structure as close as nodejs/node one will help keeping the code up-to-date. We can also use package imports for the require calls to be as close as the upstream ones as possible.
juliangruber
requested changes
Apr 20, 2022
bin/test_runner.js
Outdated
| @@ -1,5 +1,5 @@ | |||
| #!/usr/bin/env node | |||
| // https://github.com/cjihrig/node/blob/484d35402de36d8d5756b244c8e5fbb8aa4c6afd/lib/internal/main/test_runner.js | |||
| // https://github.com/nodejs/node/blob/HEAD/lib/internal/main/test_runner.js | |||
There was a problem hiding this comment.
+1 for changing the repo, I liked keeping the sha in there so you could tell exactly which file this was ported from. What do you think?
lib/internal/errors.js
Outdated
| const expectedLength = | ||
| (StringPrototypeMatch(msg, /%[dfijoOs]/g) || []).length | ||
| const expectedLength = (StringPrototypeMatch(msg, /%[dfijoOs]/g) || []) | ||
| .length |
There was a problem hiding this comment.
about the style changes, shall we move away from standard to match node core closer (with semicolons and all)?
There was a problem hiding this comment.
Ugh, that's my VSCode config that's messing with me, trying to run Prettier on standard files
There was a problem hiding this comment.
I was using prettier-standard before but realized it was unmaintained
| @@ -0,0 +1,221 @@ | |||
| // https://github.com/nodejs/node/blob/HEAD/lib/internal/test_runner/tap_stream.js | |||
There was a problem hiding this comment.
some of these files exist twice now
juliangruber
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the file structure as close as nodejs/node one will help keeping
the code up-to-date. We can also use package imports for the require
calls to be as close as the upstream ones as possible.